Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 7231008: Fix an overflow in on-stack replacement spill-slot allocation for Crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler.cc ('k') | src/lithium.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2150 matching lines...) Expand 10 before | Expand all | Expand 10 after
2161 2161
2162 2162
2163 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2163 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2164 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2164 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2165 return DefineAsSpilled(new LParameter, spill_index); 2165 return DefineAsSpilled(new LParameter, spill_index);
2166 } 2166 }
2167 2167
2168 2168
2169 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2169 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2170 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2170 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2171 if (spill_index > LUnallocated::kMaxFixedIndex) {
2172 Abort("Too many spill slots needed for OSR");
2173 }
2171 return DefineAsSpilled(new LUnknownOSRValue, spill_index); 2174 return DefineAsSpilled(new LUnknownOSRValue, spill_index);
2172 } 2175 }
2173 2176
2174 2177
2175 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) { 2178 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) {
2176 LOperand* context = UseFixed(instr->context(), esi); 2179 LOperand* context = UseFixed(instr->context(), esi);
2177 argument_count_ -= instr->argument_count(); 2180 argument_count_ -= instr->argument_count();
2178 LCallStub* result = new LCallStub(context); 2181 LCallStub* result = new LCallStub(context);
2179 return MarkAsCall(DefineFixed(result, eax), instr); 2182 return MarkAsCall(DefineFixed(result, eax), instr);
2180 } 2183 }
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
2283 LOperand* key = UseOrConstantAtStart(instr->key()); 2286 LOperand* key = UseOrConstantAtStart(instr->key());
2284 LOperand* object = UseOrConstantAtStart(instr->object()); 2287 LOperand* object = UseOrConstantAtStart(instr->object());
2285 LIn* result = new LIn(key, object); 2288 LIn* result = new LIn(key, object);
2286 return MarkAsCall(DefineFixed(result, eax), instr); 2289 return MarkAsCall(DefineFixed(result, eax), instr);
2287 } 2290 }
2288 2291
2289 2292
2290 } } // namespace v8::internal 2293 } } // namespace v8::internal
2291 2294
2292 #endif // V8_TARGET_ARCH_IA32 2295 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/lithium.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698