Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 7231008: Fix an overflow in on-stack replacement spill-slot allocation for Crankshaft. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2102 matching lines...) Expand 10 before | Expand all | Expand 10 after
2113 2113
2114 2114
2115 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2115 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2116 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2116 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2117 return DefineAsSpilled(new LParameter, spill_index); 2117 return DefineAsSpilled(new LParameter, spill_index);
2118 } 2118 }
2119 2119
2120 2120
2121 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2121 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2122 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2122 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2123 if (spill_index > LUnallocated::kMaxFixedIndex) {
2124 Abort("Too many spill slots needed for OSR");
2125 }
2123 return DefineAsSpilled(new LUnknownOSRValue, spill_index); 2126 return DefineAsSpilled(new LUnknownOSRValue, spill_index);
2124 } 2127 }
2125 2128
2126 2129
2127 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) { 2130 LInstruction* LChunkBuilder::DoCallStub(HCallStub* instr) {
2128 argument_count_ -= instr->argument_count(); 2131 argument_count_ -= instr->argument_count();
2129 return MarkAsCall(DefineFixed(new LCallStub, r0), instr); 2132 return MarkAsCall(DefineFixed(new LCallStub, r0), instr);
2130 } 2133 }
2131 2134
2132 2135
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
2230 2233
2231 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2234 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2232 LOperand* key = UseRegisterAtStart(instr->key()); 2235 LOperand* key = UseRegisterAtStart(instr->key());
2233 LOperand* object = UseRegisterAtStart(instr->object()); 2236 LOperand* object = UseRegisterAtStart(instr->object());
2234 LIn* result = new LIn(key, object); 2237 LIn* result = new LIn(key, object);
2235 return MarkAsCall(DefineFixed(result, r0), instr); 2238 return MarkAsCall(DefineFixed(result, r0), instr);
2236 } 2239 }
2237 2240
2238 2241
2239 } } // namespace v8::internal 2242 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698