Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 7230057: Revert 90805 - I am submitting this with LGTMs from agl@ and evanm@. I'm marking this as TBR=jam@... (Closed)

Created:
9 years, 5 months ago by Ami GONE FROM CHROMIUM
Modified:
9 years, 5 months ago
Reviewers:
Brad Chen
CC:
chromium-reviews, joi+watch-content_chromium.org, native-client-reviews_googlegroups.com, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 90805 - I am submitting this with LGTMs from agl@ and evanm@. I'm marking this as TBR=jam@ because he is on vacation. He previously LGTMed the reverted CL (link below) and there are not substantive changes since then. Modify the Chrome Linux zygote to support a nacl_helper executable, facilitating a special address-space layout as required by NaCl on ARM and ATOM CPUs. In passing, simplify some shared elements of launching NaCl modules in Chrome. This is an update to a previously reverted CL. Please see http://codereview.chromium.org/6995121 for the earlier reviews. Patching nacl_helper CL into fresh branch. BUG=nativeclient:480 TEST=nativeclient in-browser tests TBR=jam@chromium.org TBR=bradchen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -761 lines) Patch
MM base/process_util.h View 1 chunk +0 lines, -9 lines 0 comments Download
MM base/process_util_posix.cc View 3 chunks +5 lines, -32 lines 0 comments Download
MM chrome/app/chrome_main.cc View 3 chunks +2 lines, -10 lines 0 comments Download
D chrome/common/nacl_fork_delegate_linux.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/common/nacl_helper_linux.h View 1 chunk +0 lines, -46 lines 0 comments Download
MM chrome/common/nacl_types.h View 3 chunks +2 lines, -4 lines 0 comments Download
MM chrome/nacl.gypi View 3 chunks +2 lines, -22 lines 0 comments Download
D chrome/nacl/nacl_fork_delegate_linux.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/nacl/nacl_helper_linux.cc View 1 chunk +0 lines, -167 lines 0 comments Download
A + chrome/nacl/nacl_launcher_thread.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/nacl/nacl_launcher_thread.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/nacl/nacl_listener.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/nacl/nacl_listener.cc View 1 chunk +0 lines, -135 lines 0 comments Download
MM chrome/nacl/nacl_main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
MM content/browser/child_process_launcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
MM content/browser/zygote_host_linux.h View 2 chunks +4 lines, -6 lines 0 comments Download
MM content/browser/zygote_host_linux.cc View 3 chunks +4 lines, -6 lines 0 comments Download
MM content/browser/zygote_main_linux.cc View 13 chunks +34 lines, -72 lines 0 comments Download
MM content/common/content_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
MM content/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
MM content/common/sandbox_methods_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/zygote_fork_delegate_linux.h View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ami GONE FROM CHROMIUM
9 years, 5 months ago (2011-06-28 19:06:35 UTC) #1
Brad Chen
9 years, 5 months ago (2011-06-28 19:08:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698