chrome/common/extensions/api/extension_api.json - Issue 7229012: Use extension match pattern syntax in content settings extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 7229012: Use extension match pattern syntax in content settings extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: unit test Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_content_settings_unittest.cc ('K') | « chrome/chrome_tests.gypi ('k') | chrome/common/extensions/docs/examples/api/contentSettings.zip » ('j') | chrome/common/extensions/url_pattern.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_api.json

diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json

index d507be19a632f916dd739361dde37adda10d8275..283f8175abeedb36a3e79dadf9337694d09f5a44 100644

--- a/chrome/common/extensions/api/extension_api.json

+++ b/chrome/common/extensions/api/extension_api.json

@@ -5802,26 +5802,16 @@

"description": "Currently, no content types use resource identifiers."

{

- "id": "Pattern",

- "type": "object",

- "properties": {

- "pattern": {

- "type": "string",

- "description": "The pattern string. The pattern should never be constructed directly, but should always be derived from an URL using the methods in the <var>contentSettings.patterns</var> module."

- }

- },

- {

"id": "ContentSettingRule",

"type": "object",

"properties": {

"topLevelPattern": {

- "$ref": "Pattern",

- "description": "The pattern for the top-level frame URL."

+ "type": "string",

+ "description": "The pattern for the top-level frame URL. For details on the format of a pattern, see <a href='match_patterns.html'>Match Patterns</a>."

"embeddedPattern": {

- "$ref": "Pattern",

- "description": "The pattern for the frame or object URL."

+ "type": "string",

+ "description": "The pattern for the frame or object URL. For details on the format of a pattern, see <a href='match_patterns.html'>Match Patterns</a>."

"resourceIdentifier": {

"$ref": "ResourceIdentifier",

@@ -5920,12 +5910,12 @@

"type": "object",

"properties": {

"topLevelPattern": {

- "$ref": "Pattern",

- "description": "The pattern for the top-level frame URL."

+ "type": "string",

+ "description": "The pattern for the top-level frame URL. For details on the format of a pattern, see <a href='match_patterns.html'>Match Patterns</a>."

"embeddedPattern": {

- "$ref": "Pattern",

- "description": "The pattern for the frame or object URL."

+ "type": "string",

+ "description": "The pattern for the frame or object URL. For details on the format of a pattern, see <a href='match_patterns.html'>Match Patterns</a>."

"resourceIdentifier": {

"$ref": "ResourceIdentifier",