Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7666)

Unified Diff: chrome/common/extensions/extension.cc

Issue 7229012: Use extension match pattern syntax in content settings extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: initialize port Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index e98c5f08cce60461e79b3f28b20ab6d7327136d6..e813b999b2e5f6f9513b7e9e9a54542590da8151 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -374,8 +374,8 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,
UserScript* result) {
// When strict error checks are enabled, make URL pattern parsing strict.
URLPattern::ParseOption parse_strictness =
- (flags & STRICT_ERROR_CHECKS ? URLPattern::PARSE_STRICT
- : URLPattern::PARSE_LENIENT);
+ (flags & STRICT_ERROR_CHECKS ? URLPattern::ERROR_ON_PORTS
+ : URLPattern::IGNORE_PORTS);
// run_at
if (content_script->HasKey(keys::kRunAt)) {
@@ -785,8 +785,8 @@ FileBrowserHandler* Extension::LoadFileBrowserHandler(
return NULL;
}
URLPattern pattern(URLPattern::SCHEME_FILESYSTEM);
- if (URLPattern::PARSE_SUCCESS != pattern.Parse(filter,
- URLPattern::PARSE_STRICT)) {
+ if (pattern.Parse(filter, URLPattern::ERROR_ON_PORTS) !=
+ URLPattern::PARSE_SUCCESS) {
*error = ExtensionErrorUtils::FormatErrorMessage(
errors::kInvalidURLPatternError, filter);
return NULL;
@@ -1035,7 +1035,7 @@ bool Extension::LoadLaunchURL(const DictionaryValue* manifest,
launch_web_url_ = gallery_url.spec();
URLPattern pattern(kValidWebExtentSchemes);
- pattern.Parse(gallery_url.spec(), URLPattern::PARSE_STRICT);
+ pattern.Parse(gallery_url.spec(), URLPattern::ERROR_ON_PORTS);
pattern.SetPath(pattern.path() + '*');
extent_.AddPattern(pattern);
}
@@ -1323,8 +1323,8 @@ bool Extension::InitFromValue(const DictionaryValue& source, int flags,
std::string* error) {
// When strict error checks are enabled, make URL pattern parsing strict.
URLPattern::ParseOption parse_strictness =
- (flags & STRICT_ERROR_CHECKS ? URLPattern::PARSE_STRICT
- : URLPattern::PARSE_LENIENT);
+ (flags & STRICT_ERROR_CHECKS ? URLPattern::ERROR_ON_PORTS
+ : URLPattern::IGNORE_PORTS);
// Initialize permissions with an empty, default permission set.
permission_set_.reset(new ExtensionPermissionSet());

Powered by Google App Engine
This is Rietveld 408576698