chrome/browser/extensions/extension_webrequest_api.cc - Issue 7229012: Use extension match pattern syntax in content settings extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webrequest_api.cc

Issue 7229012: Use extension match pattern syntax in content settings extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: initialize port Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webrequest_api.cc

diff --git a/chrome/browser/extensions/extension_webrequest_api.cc b/chrome/browser/extensions/extension_webrequest_api.cc

index ce464699b0f89578ccb9a270f13f10ec5c4b179e..df3a9ee12a34930b027af5fd0548767f158631a0 100644

--- a/chrome/browser/extensions/extension_webrequest_api.cc

+++ b/chrome/browser/extensions/extension_webrequest_api.cc

@@ -238,7 +238,7 @@ bool ExtensionWebRequestEventRouter::RequestFilter::InitFromValue(

std::string url;

URLPattern pattern(URLPattern::SCHEME_ALL);

if (!urls_value->GetString(i, &url) ||

- pattern.Parse(url, URLPattern::PARSE_STRICT) !=

+ pattern.Parse(url, URLPattern::ERROR_ON_PORTS) !=

URLPattern::PARSE_SUCCESS) {

*error = ExtensionErrorUtils::FormatErrorMessage(

keys::kInvalidRequestFilterUrl, url);