chrome/browser/extensions/extension_context_menu_api.cc - Issue 7229012: Use extension match pattern syntax in content settings extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_api.cc

Issue 7229012: Use extension match pattern syntax in content settings extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: initialize port Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_context_menu_api.cc

diff --git a/chrome/browser/extensions/extension_context_menu_api.cc b/chrome/browser/extensions/extension_context_menu_api.cc

index 50d08b741676da5100eaa1a8f0df6252aea24d1d..d5f1e01326b317d8b3572015dbbd220ef93c8e31 100644

--- a/chrome/browser/extensions/extension_context_menu_api.cc

+++ b/chrome/browser/extensions/extension_context_menu_api.cc

@@ -143,7 +143,7 @@ bool ExtensionContextMenuFunction::ParseURLPatterns(

// TODO(skerner): Consider enabling strict pattern parsing

// if this extension's location indicates that it is under development.

if (URLPattern::PARSE_SUCCESS != pattern.Parse(tmp,

- URLPattern::PARSE_LENIENT)) {

+ URLPattern::IGNORE_PORTS)) {

error_ = ExtensionErrorUtils::FormatErrorMessage(kInvalidURLPatternError,

tmp);

return false;