Add possibility to configure 'prototype' property via FunctionTemplate

Add possibility to configure 'prototype' property via FunctionTemplate


BUG=v8:1479
TEST=test-api/SetPrototypeProperties

Committed: http://code.google.com/p/v8/source/detail?r=8366

[Jakob Kummerow, 2011-06-22 11:43:45]

PTAL.

Is there a nicer way to write the tests, i.e. one that doesn't require using
CompileRun()? I haven't found a C++ equivalent to
Object.getOwnPropertyDescriptor().

[Mads Ager (chromium), 2011-06-22 12:13:46]

A bit of renaming is needed, but other than that it looks good.

API tests are unfortunately verbose. What you have here looks as I would expect.

http://codereview.chromium.org/7229007/diff/2001/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/7229007/diff/2001/include/v8.h#newcode2147
include/v8.h:2147: * Sets the properties of the 'prototype' property of
functions created
the properties -> the property attributes.

http://codereview.chromium.org/7229007/diff/2001/include/v8.h#newcode2151
include/v8.h:2151: void SetPrototypeProperties(int flags);
These flags are normally called property attributes. So let's use something
like:

SetPrototypePropertyAttributes(int attributes);

http://codereview.chromium.org/7229007/diff/2001/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/7229007/diff/2001/src/api.cc#newcode1110
src/api.cc:1110: void FunctionTemplate::SetPrototypeProperties(int flags) {
SetPrototypeAttributes or SetPrototypePropertyAttributes. We should carry out
renamings like that throughout this changelist.

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:6846:
ASSERT(i::FunctionTemplateInfo::kPrototypePropertiesOffset ==
This assert seems like an internal detail that we don't really care about. You
could add a static assert somewhere in the code with a comment to update
apinatives.h if this changes. However, I think this test will fail in that case
anyway.

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:6883: }
Let's add a test for the combination of all three as well.

[Jakob Kummerow, 2011-06-22 12:36:59]

http://codereview.chromium.org/7229007/diff/2001/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/7229007/diff/2001/include/v8.h#newcode2147
include/v8.h:2147: * Sets the properties of the 'prototype' property of
functions created
On 2011/06/22 12:13:46, Mads Ager wrote:
> the properties -> the property attributes.

Done.

http://codereview.chromium.org/7229007/diff/2001/include/v8.h#newcode2151
include/v8.h:2151: void SetPrototypeProperties(int flags);
On 2011/06/22 12:13:46, Mads Ager wrote:
> These flags are normally called property attributes. So let's use something
> like:
> 
> SetPrototypePropertyAttributes(int attributes);

Done.

http://codereview.chromium.org/7229007/diff/2001/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/7229007/diff/2001/src/api.cc#newcode1110
src/api.cc:1110: void FunctionTemplate::SetPrototypeProperties(int flags) {
On 2011/06/22 12:13:46, Mads Ager wrote:
> SetPrototypeAttributes or SetPrototypePropertyAttributes. We should carry out
> renamings like that throughout this changelist.

Done.
"SetPrototypeAttributes" is long enough, so I've chosen that name.

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:6846:
ASSERT(i::FunctionTemplateInfo::kPrototypePropertiesOffset ==
On 2011/06/22 12:13:46, Mads Ager wrote:
> This assert seems like an internal detail that we don't really care about. You
> could add a static assert somewhere in the code with a comment to update
> apinatives.h if this changes. However, I think this test will fail in that
case
> anyway.

Done. Removed.

http://codereview.chromium.org/7229007/diff/2001/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:6883: }
On 2011/06/22 12:13:46, Mads Ager wrote:
> Let's add a test for the combination of all three as well.

Done.

[Mads Ager (chromium), 2011-06-22 12:39:01]

LGTM!