Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3784)

Unified Diff: chrome/browser/content_settings/host_content_settings_map.cc

Issue 7229005: Include port when creating a pattern for a HTTPS URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_settings/content_settings_pattern_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/host_content_settings_map.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map.cc b/chrome/browser/content_settings/host_content_settings_map.cc
index 419921c23aea505d460f80ff72188db5a3e8bf06..827682819ff57c1c386b99a6e7e80c677946ce87 100644
--- a/chrome/browser/content_settings/host_content_settings_map.cc
+++ b/chrome/browser/content_settings/host_content_settings_map.cc
@@ -366,6 +366,9 @@ void HostContentSettingsMap::AddExceptionForURL(
// Make sure there is no entry that would override the pattern we are about
// to insert for exactly this URL.
+
+ // TODO(markusheintz): For cookies, the pattern and wildcard parameter need
+ // to be switched.
Bernhard Bauer 2011/06/22 09:49:11 It should be correct this way; we switched to prim
markusheintz_ 2011/06/22 10:53:08 +1 for Bernhard's comment. That's way easier to m
SetContentSetting(ContentSettingsPattern::FromURLNoWildcard(primary_url),
ContentSettingsPattern::Wildcard(),
content_type,
« no previous file with comments | « chrome/browser/content_settings/content_settings_pattern_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698