Include port when creating a pattern for a HTTPS URL

Include port when creating a pattern for a HTTPS URL

BUG=none
TEST=unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90042

[jochen (gone - plz use gerrit), 2011-06-22 09:26:48]

plz review

Markus, one thing that occurred to me is that AddExceptionForURL adds invalid
exceptions for cookies: the wildcard should be the toplevel URL

[Bernhard Bauer, 2011-06-22 09:49:11]

http://codereview.chromium.org/7229005/diff/1/chrome/browser/content_settings...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/7229005/diff/1/chrome/browser/content_settings...
chrome/browser/content_settings/host_content_settings_map.cc:371: // to be
switched.
It should be correct this way; we switched to primary and secondary URLs and
patterns instead of top-level/embedded exactly to get that right (as in: the
primary URL for cookies is the cookie URL, while for most other types it's the
top-level frame URL, and we add wildcards for the secondary URL).

[markusheintz_, 2011-06-22 10:53:08]

http://codereview.chromium.org/7229005/diff/1/chrome/browser/content_settings...
File chrome/browser/content_settings/host_content_settings_map.cc (right):

http://codereview.chromium.org/7229005/diff/1/chrome/browser/content_settings...
chrome/browser/content_settings/host_content_settings_map.cc:371: // to be
switched.
+1 for Bernhard's comment.

That's way easier to maintain as the host content settings map should not need
to care about the semantics of the primary and secondary pattern.

[jochen (gone - plz use gerrit), 2011-06-22 13:19:36]

PTAL

[Bernhard Bauer, 2011-06-22 13:25:23]

On 2011/06/22 13:19:36, jochen wrote:
> PTAL

LGTM.

[markusheintz_, 2011-06-22 13:25:34]

LGTM

[Bernhard Bauer, 2011-06-22 13:26:03]

On 2011/06/22 13:25:23, Bernhard Bauer wrote:
> On 2011/06/22 13:19:36, jochen wrote:
> > PTAL
> 
> LGTM.

AutocompleteTest.InputType seems to be broken on trunk, no?

[jochen (gone - plz use gerrit), 2011-06-22 13:27:11]

On Wed, Jun 22, 2011 at 3:26 PM, <bauerb@chromium.org> wrote:

> On 2011/06/22 13:25:23, Bernhard Bauer wrote:
>
>> On 2011/06/22 13:19:36, jochen wrote:
>> > PTAL
>>
>
>  LGTM.
>>
>
> AutocompleteTest.InputType seems to be broken on trunk, no?


yeah, I'm getting this on all my tryjobs today :-/


>
>
>
http://codereview.chromium.**org/7229005/<http://codereview.chromium.org/7229...
>

[commit-bot: I haz the power, 2011-06-22 17:27:25]

Change committed as 90042