Issue 7227025: ntp4: fix app context menu z-order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7227025: ntp4: fix app context menu z-order (Closed)

Created:
9 years, 5 months ago by Evan Stade

Modified:
9 years, 5 months ago

Reviewers:
Rick Byers

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: some context menu fixes 1 - z-order: make it show on top of the footer 2 - disable uninstall when appropriate 3 - fix appearance of disabled items on linux/gtk (applies to all places menu.js is used) BUG=none TEST=see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91740

Patch Set 1 #

Patch Set 2 : many more fixes #

Total comments: 1

Patch Set 3 : added bug ref #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
M	chrome/browser/resources/bookmark_manager/js/main.js	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/resources/new_tab.js	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/css/menu.css	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rick Byers

9 years, 5 months ago (2011-07-07 16:42:22 UTC) #2

LGTM

http://codereview.chromium.org/7227025/diff/1002/chrome/browser/resources/sha...
File chrome/browser/resources/shared/css/menu.css (right):

http://codereview.chromium.org/7227025/diff/1002/chrome/browser/resources/sha...
chrome/browser/resources/shared/css/menu.css:49: /* Text alpha doesn't work on
Linux/GTK. TODO(estade): investigate.  */
Can you just file a bug for this now (and reference the bug number here) so we
don't forget about it?

Expand Messages | Collapse Messages