Create and use shared stub for for DictionaryValue-based elements.

src/code-stubs.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 226 matching lines @@
 
   OS::SNPrintF(Vector<char>(name_, kMaxNameLength),
                "InstanceofStub%s%s%s",
                args,
                inline_check,
                return_true_false_object);
   return name_;
 }
 
 
-void KeyedLoadFastElementStub::Generate(MacroAssembler* masm) {
-  KeyedLoadStubCompiler::GenerateLoadFastElement(masm);
+void KeyedLoadElementStub::Generate(MacroAssembler* masm) {
+  switch (elements_kind_) {
+  case JSObject::FAST_ELEMENTS:

[Jakob Kummerow, 2011/07/07 13:55:38]

nit: indent "case" lines inside "switch" statements.

[danno, 2011/07/08 11:00:24]

Done.

+    KeyedLoadStubCompiler::GenerateLoadFastElement(masm);
+    break;
+  case JSObject::FAST_DOUBLE_ELEMENTS:
+    UNIMPLEMENTED();
+    break;
+  case JSObject::EXTERNAL_BYTE_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
+  case JSObject::EXTERNAL_SHORT_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
+  case JSObject::EXTERNAL_INT_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_INT_ELEMENTS:
+  case JSObject::EXTERNAL_FLOAT_ELEMENTS:
+  case JSObject::EXTERNAL_DOUBLE_ELEMENTS:
+  case JSObject::EXTERNAL_PIXEL_ELEMENTS:
+    KeyedLoadStubCompiler::GenerateLoadExternalArray(masm, elements_kind_);
+    break;
+  case JSObject::DICTIONARY_ELEMENTS:
+    KeyedLoadStubCompiler::GenerateLoadDictionaryElement(masm);
+    break;
+  case JSObject::NON_STRICT_ARGUMENTS_ELEMENTS:
+    UNREACHABLE();
+    break;
+  }
 }
 
 
-void KeyedStoreFastElementStub::Generate(MacroAssembler* masm) {
-  KeyedStoreStubCompiler::GenerateStoreFastElement(masm, is_js_array_);
+void KeyedStoreElementStub::Generate(MacroAssembler* masm) {
+  switch (elements_kind_) {
+  case JSObject::FAST_ELEMENTS:

[Jakob Kummerow, 2011/07/07 13:55:38]

Same indentation nit here.

[danno, 2011/07/08 11:00:24]

Done.

+    KeyedStoreStubCompiler::GenerateStoreFastElement(masm, is_js_array_);
+    break;
+  case JSObject::FAST_DOUBLE_ELEMENTS:
+    UNIMPLEMENTED();
+    break;
+  case JSObject::EXTERNAL_BYTE_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
+  case JSObject::EXTERNAL_SHORT_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
+  case JSObject::EXTERNAL_INT_ELEMENTS:
+  case JSObject::EXTERNAL_UNSIGNED_INT_ELEMENTS:
+  case JSObject::EXTERNAL_FLOAT_ELEMENTS:
+  case JSObject::EXTERNAL_DOUBLE_ELEMENTS:
+  case JSObject::EXTERNAL_PIXEL_ELEMENTS:
+    KeyedStoreStubCompiler::GenerateStoreExternalArray(masm, elements_kind_);
+    break;
+  case JSObject::DICTIONARY_ELEMENTS:
+    KeyedStoreStubCompiler::GenerateStoreDictionaryElement(masm);
+    break;
+  case JSObject::NON_STRICT_ARGUMENTS_ELEMENTS:
+    UNREACHABLE();
+    break;
+  }
 }
 
 
-void KeyedLoadExternalArrayStub::Generate(MacroAssembler* masm) {
-  KeyedLoadStubCompiler::GenerateLoadExternalArray(masm, elements_kind_);
-}
-
-
-void KeyedStoreExternalArrayStub::Generate(MacroAssembler* masm) {
-  KeyedStoreStubCompiler::GenerateStoreExternalArray(masm, elements_kind_);
-}
-
-
 } }  // namespace v8::internal