[Mac] Show correct cursor after context menu is closed.

chrome/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 219 matching lines @@
 
 RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget)
     : render_widget_host_(widget),
       about_to_validate_and_paint_(false),
       call_set_needs_display_in_rect_pending_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_NONE),
       spellcheck_enabled_(false),
       spellcheck_checked_(false),
       is_loading_(false),
       is_hidden_(false),
+      is_showing_context_menu_(false),
       shutdown_factory_(this),
       needs_gpu_visibility_update_after_repaint_(false),
       compositing_surface_(gfx::kNullPluginWindow) {
   // |cocoa_view_| owns us and we will be deleted when |cocoa_view_| goes away.
   // Since we autorelease it, our caller must put |native_view()| into the view
   // hierarchy right after calling us.
   cocoa_view_ = [[[RenderWidgetHostViewCocoa alloc]
                   initWithRenderWidgetHostViewMac:this] autorelease];
   render_widget_host_->SetView(this);
 
@@ skipping 216 matching lines @@
 }
 
 void RenderWidgetHostViewMac::UpdateCursor(const WebCursor& cursor) {
   current_cursor_ = cursor;
   UpdateCursorIfNecessary();
 }
 
 void RenderWidgetHostViewMac::UpdateCursorIfNecessary() {
   // Do something special (as Win Chromium does) for arrow cursor while loading
   // a page? TODO(avi): decide
+
+  // Don't update the cursor if a context menu is being shown.
+  if (is_showing_context_menu_)
+    return;
+
   // Can we synchronize to the event stream? Switch to -[NSWindow
   // mouseLocationOutsideOfEventStream] if we cannot. TODO(avi): test and see
   NSEvent* event = [[cocoa_view_ window] currentEvent];
   if ([event window] != [cocoa_view_ window])
     return;
 
   NSCursor* ns_cursor = current_cursor_.GetCursor();
   [ns_cursor set];
 }
 
@@ skipping 149 matching lines @@
 //
 // RenderWidgetHostViewCocoa uses the stored selection text,
 // which implements NSServicesRequests protocol.
 //
 void RenderWidgetHostViewMac::SelectionChanged(const std::string& text,
                                                const ui::Range& range) {
   selected_text_ = text;
   [cocoa_view_ setSelectedRange:range.ToNSRange()];
 }
 
+void RenderWidgetHostViewMac::ShowingContextMenu(bool showing) {
+  DCHECK_NE(is_showing_context_menu_, showing);
+  is_showing_context_menu_ = showing;
+
+  // Create a fake mouse event to inform the render widget that the mouse
+  // left or entered.
+  NSWindow* window = [cocoa_view_ window];
+  NSPoint location = [window mouseLocationOutsideOfEventStream];

[Mark Mentovai, 2011/07/12 14:06:57]

“outside of event stream”—is this a good idea? What if the current event
([NSEvent currentEvent]) lags the “physical” world because processing was
delayed?

There’s another TODO about this in this file, and we use -[NSWindow
mouseLocationOutsideOfEventStream] elsewhere in Chrome. It may not be the best
choice in those locations either.

+  NSEvent* event = [NSEvent mouseEventWithType:NSMouseMoved
+                                      location:location
+                                 modifierFlags:0
+                                     timestamp:0
+                                  windowNumber:[window windowNumber]
+                                       context:nil
+                                   eventNumber:0
+                                    clickCount:0
+                                      pressure:0];
+  WebMouseEvent web_event =
+      WebInputEventFactory::mouseEvent(event, cocoa_view_);
+  if (showing)
+    web_event.type = WebInputEvent::MouseLeave;
+  render_widget_host_->ForwardMouseEvent(web_event);
+}
+
 bool RenderWidgetHostViewMac::IsPopup() const {
   return popup_type_ != WebKit::WebPopupTypeNone;
 }
 
 BackingStore* RenderWidgetHostViewMac::AllocBackingStore(
     const gfx::Size& size) {
   return new BackingStoreMac(render_widget_host_, size);
 }
 
 // Sets whether or not to accept first responder status.
@@ skipping 1934 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end