Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 7227003: Add virtual destructors for the Pepper API thunks. (Closed)

Created:
9 years, 6 months ago by brettw
Modified:
9 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Add virtual destructors for the Pepper API thunks. TEST=it compiles BUG=86132 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -12 lines) Patch
M ppapi/thunk/ppb_audio_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_audio_config_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_audio_trusted_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_broker_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_buffer_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_buffer_trusted_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_char_set_api.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_context_3d_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_cursor_control_api.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_directory_reader_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_file_chooser_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
ppapi/thunk/ppb_file_io_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_file_ref_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_file_system_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_find_api.h View 1 chunk +4 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_flash_menu_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_flash_net_connector_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_font_api.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_graphics_2d_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_image_data_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_layer_compositor_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_pdf_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_scrollbar_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
ppapi/thunk/ppb_surface_3d_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_transport_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_url_loader_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_url_request_info_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_url_response_info_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_video_decoder_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_video_layer_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_widget_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 6 months ago (2011-06-27 21:27:57 UTC) #1
yzshen1
9 years, 6 months ago (2011-06-27 21:41:22 UTC) #2
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698