Issue 7226: - Inlined JSArray::SetContent....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7226: - Inlined JSArray::SetContent.... (Closed)

Created:
12 years, 2 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Inlined JSArray::SetContent. - Implemented Runtime_KeyedGetProperty to make slow case faster. Committed: http://code.google.com/p/v8/source/detail?r=487

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -10 lines)			Patch
M	src/ic-ia32.cc	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/property.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+23 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-10 09:32:06 UTC) #2

LGTM. Comments:

http://codereview.chromium.org/7226/diff/1/2
File src/ic-ia32.cc (right):

http://codereview.chromium.org/7226/diff/1/2#newcode215
Line 215: Label slow, fast, check_string, slow_string;
The slow_string label doesn't appear to be used?

http://codereview.chromium.org/7226/diff/1/2#newcode248
Line 248: KeyedLoadIC::Generate(masm,
ExternalReference(Runtime::kKeyedGetProperty));
Maybe you should port this change to ARM right away? Should be fairly trivial...

http://codereview.chromium.org/7226/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/7226/diff/1/4#newcode1465
Line 1465: && key->IsString()
Why not have the && on the previous line?

http://codereview.chromium.org/7226/diff/1/4#newcode1466
Line 1466: && !JSObject::cast(receiver)->HasFastProperties()) {
Ditto.

http://codereview.chromium.org/7226/diff/1/4#newcode1470
Line 1470: && (dictionary->DetailsAt(entry).type() == NORMAL)) {
Ditto.

Expand Messages | Collapse Messages