Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser.cc

Issue 7224002: Fix a crash in Chrome when clicking on the "Settings..." menu item for a desktop notification sho... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
===================================================================
--- chrome/browser/ui/browser.cc (revision 89645)
+++ chrome/browser/ui/browser.cc (working copy)
@@ -1990,7 +1990,8 @@
GURL(chrome::kChromeUISettingsURL + sub_page)));
params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
- if ((GetSelectedTabContents()->GetURL() == GURL(chrome::kChromeUINewTabURL) ||
+ if (GetSelectedTabContents() != NULL &&
+ (GetSelectedTabContents()->GetURL() == GURL(chrome::kChromeUINewTabURL) ||
GetSelectedTabContents()->GetURL() == GURL(chrome::kAboutBlankURL)) &&
browser::GetIndexOfSingletonTab(&params) < 0) {
params.disposition = CURRENT_TAB;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698