Issue 7224002: Fix a crash in Chrome when clicking on the "Settings..." menu item for a desktop notification sho...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7224002: Fix a crash in Chrome when clicking on the "Settings..." menu item for a desktop notification sho... (Closed)

Created:
9 years, 6 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in Chrome when clicking on the "Settings..." menu item for a desktop notification shown through Chrome Frame. BUG=86988 TEST=Click on the "Settings..." menu on a desktop notification shown in Chrome Frame. Observe that Chrome does not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90122

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/ui/browser.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Greg Billock

9 years, 6 months ago (2011-06-22 18:09:06 UTC) #2

LGTM. Thanks! (I don't have committer status, so you may need a stamp from
someone else, too, I'm not sure.)

Expand Messages | Collapse Messages