Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 7222028: Add Makefile for yasm on Windows. (Closed)

Created:
9 years, 6 months ago by Alpha Left Google
Modified:
9 years, 5 months ago
Reviewers:
Wez
CC:
chromium-reviews
Visibility:
Public.

Description

Add Makefile for yasm on Windows. Makefile for yasm is missing on Windows, causing build to fail. Building YASM on Windows is required to build libvpx and ffmpeg. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3822 lines, -0 lines) Patch
A third_party/yasm/source/config/win/Makefile View 1 chunk +3822 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
9 years, 6 months ago (2011-06-24 23:34:58 UTC) #1
Wez
Where does has this Makefile come from? Would it make sense to gyp-ify it instead ...
9 years, 6 months ago (2011-06-27 20:31:01 UTC) #2
Alpha Left Google
On 2011/06/27 20:31:01, Wez wrote: > Where does has this Makefile come from? Would it ...
9 years, 6 months ago (2011-06-27 20:32:30 UTC) #3
Wez
9 years, 6 months ago (2011-06-27 21:27:07 UTC) #4
On 2011/06/27 20:32:30, Alpha wrote:
> On 2011/06/27 20:31:01, Wez wrote:
> > Where does has this Makefile come from?  Would it make sense to gyp-ify it
> > instead of just checking it in?
> 
> This is coming from the linux version with slight modifications. We can't use
> gyp to replace this because YASM use this as an input to generate a .c file
> instead of using it as a build rule.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698