Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 7222019: Allow hyphens at the beginning of domain components, except for the last domain component. (Closed)

Created:
9 years, 6 months ago by Peter Kasting
Modified:
9 years, 6 months ago
Reviewers:
brettw, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Allow hyphens at the beginning of domain components, except for the last domain component. This is an intentional relaxation of the rules from RFC 1738 to accommodate real-world URLs like http://-kol.deviantart.com/ and http://-tumblrprincess.tumblr.com/. BUG=31060 TEST=Type one of the above URLs in the Chrome omnibox and hit enter; you should navigate, not search. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M net/base/net_util.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/net_util_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
9 years, 6 months ago (2011-06-21 21:18:21 UTC) #1
brettw
I can't load those URLs even by link clicks. Are the functions you're changing used ...
9 years, 6 months ago (2011-06-21 21:46:59 UTC) #2
Peter Kasting
On 2011/06/21 21:46:59, brettw wrote: > I can't load those URLs even by link clicks. ...
9 years, 6 months ago (2011-06-21 21:59:19 UTC) #3
brettw
I see, LGTM
9 years, 6 months ago (2011-06-21 22:02:07 UTC) #4
eroman
9 years, 6 months ago (2011-06-21 22:10:13 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698