Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 7222014: Add the /profile flag to linker options for official builds. (Closed)

Created:
9 years, 6 months ago by chrisha
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add the /profile flag to linker options for official builds. This deposits "FIXUPS" in the PDB, which grows the PDB file by 5% or so, but does not otherwise affect the generated binaries. We are applying this change to branch 648 because it is one of the reference branches we have been using in Syzygy development. It will be useful for us to continue to be able to develop against this branch in order to compare performance against earlier versions of our toolchain. For more information refer to: http://codereview.chromium.org/7106002 BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/internal/release_impl_official.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chrisha
PTAL
9 years, 6 months ago (2011-06-21 19:04:58 UTC) #1
Sigurður Ásgeirsson
lgtm, but let's wait for the go-ahead from Laforge.
9 years, 6 months ago (2011-06-21 19:08:13 UTC) #2
laforge
On 2011/06/21 19:08:13, Ruðrugis wrote: > lgtm, but let's wait for the go-ahead from Laforge. ...
9 years, 6 months ago (2011-06-21 19:13:55 UTC) #3
Sigurður Ásgeirsson
9 years, 6 months ago (2011-06-21 20:14:27 UTC) #4
On 2011/06/21 19:13:55, laforge wrote:
> On 2011/06/21 19:08:13, Ruðrugis wrote:
> > lgtm, but let's wait for the go-ahead from Laforge.
> 
> LGTM

Committed as http://codereview.chromium.org/7219015.

Powered by Google App Engine
This is Rietveld 408576698