base/platform_file_posix.cc - Issue 7222010: Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_file_posix.cc

Issue 7222010: Coverity fixes CID=15870,13529 Check pointer before assign, resource leak. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Revert to pre-79058 state Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/platform_file_posix.cc

diff --git a/base/platform_file_posix.cc b/base/platform_file_posix.cc

index 26c52d4682fe3e9451f4f4a24b08ce45f226752d..02c2f2f54854098bf0efdacb02374e419310f2f7 100644

--- a/base/platform_file_posix.cc

+++ b/base/platform_file_posix.cc

@@ -55,7 +55,8 @@ PlatformFile CreatePlatformFile(const FilePath& name, int flags,

!(flags & PLATFORM_FILE_OPEN_ALWAYS)) {

NOTREACHED();

errno = EOPNOTSUPP;

- *error_code = error_code ? PLATFORM_FILE_ERROR_FAILED : PLATFORM_FILE_OK;

+ if (error_code)

+ *error_code = PLATFORM_FILE_ERROR_FAILED;

return kInvalidPlatformFileValue;

}

« no previous file with comments | « no previous file | base/shared_memory_posix.cc » ('j') | no next file with comments »