Coverity fixes CID=15870,13529 Check pointer before assign, resource leak.

base/shared_memory_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/shared_memory.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
@@ skipping 124 matching lines @@
     fp = file_util::OpenFile(path, "w+x");
     if (fp == NULL && open_existing) {
       // "w+" will truncate if it already exists.
       fp = file_util::OpenFile(path, "a+");
       fix_size = false;
     }
   }
   if (fp && fix_size) {
     // Get current size.
     struct stat stat;
-    if (fstat(fileno(fp), &stat) != 0)
+    if (fstat(fileno(fp), &stat) != 0) {
+      file_util::CloseFile(fp);

[rvargas (doing something else), 2011/06/23 03:43:53]

nit: it seems ScopedFILE could be used by this method, but that's up to you.

       return false;
+    }
     const uint32 current_size = stat.st_size;
     if (current_size != size) {
-      if (HANDLE_EINTR(ftruncate(fileno(fp), size)) != 0)
+      if (HANDLE_EINTR(ftruncate(fileno(fp), size)) != 0) {
+        file_util::CloseFile(fp);
         return false;
-      if (fseeko(fp, size, SEEK_SET) != 0)
+      }
+      if (fseeko(fp, size, SEEK_SET) != 0) {
+        file_util::CloseFile(fp);
         return false;
+      }
     }
     created_size_ = size;
   }
   if (fp == NULL) {
 #if !defined(OS_MACOSX)
     PLOG(ERROR) << "Creating shared memory in " << path.value() << " failed";
     FilePath dir = path.DirName();
     if (access(dir.value().c_str(), W_OK | X_OK) < 0) {
       PLOG(ERROR) << "Unable to access(W_OK|X_OK) " << dir.value();
       if (dir.value() == "/dev/shm") {
@@ skipping 168 matching lines @@
   new_handle->fd = new_fd;
   new_handle->auto_close = true;
 
   if (close_self)
     Close();
 
   return true;
 }
 
 }  // namespace base