Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 7219009: Add Skia on Chrome for Mac gyp rules (Closed)

Created:
9 years, 6 months ago by _cary
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add Skia on Chrome for Mac gyp rules In addition to these rules, to build the USE_SKIA_ON_MAC_CHROME variation, define: gyp_defines='use_skia=1' As is, this does not change any existing platform, and has no new tests. BUG=79463 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89877

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M build/common.gypi View 1 3 chunks +13 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +4 lines, -3 lines 0 comments Download
M skia/skia.gyp View 1 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
_cary
9 years, 6 months ago (2011-06-21 16:58:50 UTC) #1
darin (slow to review)
LGTM w/ nits fixed http://codereview.chromium.org/7219009/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7219009/diff/1/build/common.gypi#newcode149 build/common.gypi:149: # Use Skia as WebKit ...
9 years, 6 months ago (2011-06-21 17:37:44 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-21 19:20:25 UTC) #3
Change committed as 89877

Powered by Google App Engine
This is Rietveld 408576698