Coverity Fixlet: UNINIT_CTOR

Coverity Fixlet: UNINIT_CTOR

CID=5172
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90598

[Sheridan Rawlins, 2011-06-21 16:50:28]

We're having a Coverity Fixlet today.

Nico - can you review string_tokenizer.h (CID=5172)

John - can you review trace_event.* (CID=16864)

Thanks,

-SCR

[jbates, 2011-06-21 17:12:32]

On 2011/06/21 16:50:28, Sheridan Rawlins wrote:
> We're having a Coverity Fixlet today.
> 
> Nico - can you review string_tokenizer.h (CID=5172)
> 
> John - can you review trace_event.* (CID=16864)
> 
> Thanks,
> 
> -SCR

I'm afraid the trace_event.* changes are not acceptable. The original design was
very specific to maximize performance when tracing is disabled. These changes
add two additional branches and a dynamic allocation. This would make the
tracing system unusable in performance critical code paths.

I would be happy to add annotations to have Coverity ignore this code.

-John

[Sheridan Rawlins, 2011-06-21 17:43:39]

Ok, rolled back trace_event.*

Nico - please review the string_tokenizer.h

Thanks,

-SCR

On 2011/06/21 17:12:32, jbates wrote:
> On 2011/06/21 16:50:28, Sheridan Rawlins wrote:
> > We're having a Coverity Fixlet today.
> > 
> > Nico - can you review string_tokenizer.h (CID=5172)
> > 
> > John - can you review trace_event.* (CID=16864)
> > 
> > Thanks,
> > 
> > -SCR
> 
> I'm afraid the trace_event.* changes are not acceptable. The original design
was
> very specific to maximize performance when tracing is disabled. These changes
> add two additional branches and a dynamic allocation. This would make the
> tracing system unusable in performance critical code paths.
> 
> I would be happy to add annotations to have Coverity ignore this code.
> 
> -John

[Nico, 2011-06-27 01:30:57]

LGTM

…but you will need an LG from someone in base/OWNERS as well.

[Sheridan Rawlins, 2011-06-27 15:32:07]

Brett (OWNER), please bless this coverity fix.

Thanks,

-SCR

[brettw, 2011-06-27 15:53:14]

LGTM

[commit-bot: I haz the power, 2011-06-27 17:23:30]

Change committed as 90598