Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome_frame/crash_server_init.h

Issue 7219007: Fix up crash reporting in unit tests and the Chrome Frame helper processes: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_launcher_main.cc ('k') | chrome_frame/crash_server_init.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/crash_server_init.h
===================================================================
--- chrome_frame/crash_server_init.h (revision 89645)
+++ chrome_frame/crash_server_init.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -15,12 +15,13 @@
extern const wchar_t kGoogleUpdatePipeName[];
extern const wchar_t kSystemPrincipalSid[];
-// Assume this implies headless mode and use kChromePipeName if it shows
-// up in the command line.
-extern const wchar_t kFullMemoryCrashReport[];
-
extern const MINIDUMP_TYPE kLargerDumpType;
+enum CrashReportingMode {
+ HEADLESS, // Used for testing, uses crash_service.exe for dumps.
+ NORMAL // Regular mode, uses GoogleCrashService.exe for dumps.
+};
+
// Returns a pointer to a static instance of a CustomClientInfo structure
// containing Chrome Frame specific data.
google_breakpad::CustomClientInfo* GetCustomInfo();
@@ -29,6 +30,6 @@
// constructed ExceptionHandler object. It is the responsibility of the caller
// to delete this object which will shut down the crash reporting machinery.
google_breakpad::ExceptionHandler* InitializeCrashReporting(
- const wchar_t* cmd_line);
+ CrashReportingMode mode);
#endif // CHROME_FRAME_CRASH_SERVER_INIT_H_
« no previous file with comments | « chrome_frame/chrome_launcher_main.cc ('k') | chrome_frame/crash_server_init.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698