Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: chrome/browser/content_settings/content_settings_provider.h

Issue 7218073: Explicitly ShutdownOnUIThread the HostContentSettingsMap when destroying the Profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_provider.h
diff --git a/chrome/browser/content_settings/content_settings_provider.h b/chrome/browser/content_settings/content_settings_provider.h
index b94697b2483a89c985ea106253042e5378b06948..8065dbefb96c3f948615ceed047a35fb40cda34a 100644
--- a/chrome/browser/content_settings/content_settings_provider.h
+++ b/chrome/browser/content_settings/content_settings_provider.h
@@ -42,6 +42,8 @@ class DefaultProviderInterface {
// there shouldn't be any UI shown to modify this setting.
virtual bool DefaultSettingIsManaged(
ContentSettingsType content_type) const = 0;
+
+ virtual void ShutdownOnUIThread() = 0;
};
class ProviderInterface {
@@ -103,7 +105,7 @@ class ProviderInterface {
// Resets all content settings for the given |content_type| to
// CONTENT_SETTING_DEFAULT. For content types that require a resource
- // identifier all content settings for any resource identifieres of the given
+ // identifier all content settings for any resource identifiers of the given
// |content_type| will be reset to CONTENT_SETTING_DEFAULT.
//
// This should only be called on the UI thread, and not after
@@ -115,7 +117,7 @@ class ProviderInterface {
// This methods needs to be called before destroying the Profile.
// Afterwards, none of the methods above that should only be called on the UI
// thread should be called anymore.
- virtual void ShutdownOnUIThread() {}
+ virtual void ShutdownOnUIThread() = 0;
};
} // namespace content_settings

Powered by Google App Engine
This is Rietveld 408576698