Issue 7218071: V8 buildbot: change sample to d8 from shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7218071: V8 buildbot: change sample to d8 from shell. (Closed)

Created:
9 years, 5 months ago by Rico

Modified:
9 years, 5 months ago

Reviewers:
Mads Ager (chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

Description

V8 buildbot: change sample to d8 from shell. The tools/test.py script is being updated to use D8 instead of shell (which we will strip down to what it was intentionally meant to be) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94045

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	scripts/slave/compile.py	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Wait a tick. This looks wrong. Does not LGTM.

9 years, 5 months ago (2011-06-30 07:05:08 UTC) #3

Mads Ager (chromium)

http://codereview.chromium.org/7218071/diff/2002/scripts/slave/compile.py File scripts/slave/compile.py (right): http://codereview.chromium.org/7218071/diff/2002/scripts/slave/compile.py#newcode461 scripts/slave/compile.py:461: 'sample=d8' It should not be sample=d8 it should just ...

9 years, 5 months ago (2011-06-30 07:06:24 UTC) #4

Rico

9 years, 5 months ago (2011-06-30 07:07:08 UTC) #5

LGTM

Expand Messages | Collapse Messages