Had a bug in the handle table unit test.

sandbox/src/handle_table_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include "sandbox/src/handle_table.h"
 #include "sandbox/tests/common/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 29 matching lines @@
 
   // Create a temp file so we have a handle to find.
   wchar_t temp_directory[MAX_PATH];
   wchar_t my_file[MAX_PATH];
   ASSERT_NE(::GetTempPath(MAX_PATH, temp_directory), 0u);
   ASSERT_NE(::GetTempFileName(temp_directory, L"test", 0, my_file), 0u);
   HANDLE file = ::CreateFile(my_file, FILE_ALL_ACCESS,
                              FILE_SHARE_READ | FILE_SHARE_WRITE, NULL,
                              OPEN_EXISTING, FILE_FLAG_DELETE_ON_CLOSE, NULL);
   EXPECT_NE(INVALID_HANDLE_VALUE, file);
+  string16 handle_name;
+  ASSERT_EQ(NT_SUCCESS(sandbox::GetHandleName(file, &handle_name)), true);

[nsylvain, 2011/06/30 19:21:46]

TRUE instead of true ?

[jschuh, 2011/07/01 01:24:26]

No, using a bool not BOOL.

[nsylvain, 2011/07/01 19:23:28]

NT_SUCCESS returns TRUE or FALSE, and ASSERT_EQ compares that with "true", this
will work, but i think it is more correct to use TRUE.

 
   // Look for the handle in our process
   bool handle_found = false;
   HandleTable handles;
   for (HandleTable::Iterator it =
       handles.HandlesForProcess(::GetCurrentProcessId());
       it != handles.end(); ++it) {
-    if (it->IsType(HandleTable::kTypeFile) && it->Name().compare(my_file)) {
+    if (it->IsType(HandleTable::kTypeFile) && it->Name() == handle_name) {
       handle_found = true;
       break;
     }
   }
   EXPECT_TRUE(handle_found);
 
   // Clean up the file we made.
   EXPECT_TRUE(::CloseHandle(file));
 }