Issue 7218065: Remove app from a bunch of DEPS files.

Issue 7218065: Remove app from a bunch of DEPS files. (Closed)

Created:
9 years, 5 months ago by tfarina

Modified:
9 years, 5 months ago

Reviewers:
Robert Sesek, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, pam+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, native-client-reviews_googlegroups.com, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove app from a bunch of DEPS files. BUG=72317 TEST=None R=rsesek@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91179

Patch Set 1 #

Total comments: 4

Patch Set 2 : Ami review #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
M	chrome/default_plugin/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/nacl/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/tools/player_x11/DEPS	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/DEPS	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	webkit/plugins/npapi/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

FYI Drive-by. http://codereview.chromium.org/7218065/diff/1/media/tools/player_x11/DEPS File media/tools/player_x11/DEPS (right): http://codereview.chromium.org/7218065/diff/1/media/tools/player_x11/DEPS#newcode1 media/tools/player_x11/DEPS:1: include_rules = [ Remove file? http://codereview.chromium.org/7218065/diff/1/ui/DEPS File ...

9 years, 5 months ago (2011-06-30 14:32:55 UTC) #2

tfarina

Please, take another look. http://codereview.chromium.org/7218065/diff/1/media/tools/player_x11/DEPS File media/tools/player_x11/DEPS (right): http://codereview.chromium.org/7218065/diff/1/media/tools/player_x11/DEPS#newcode1 media/tools/player_x11/DEPS:1: include_rules = [ On 2011/06/30 ...

9 years, 5 months ago (2011-06-30 18:00:58 UTC) #3

LGTM

Expand Messages | Collapse Messages