Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 7218056: Re-Fixes Texture::Copy (Closed)

Created:
9 years, 5 months ago by greggman
Modified:
9 years, 5 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Re-Fixes Texture::Copy The issue is Texture::Copy is being called without calling the required Texture::AllocateStorage. This happens to work because glCopyTexImage2D also allocates storage. Al would know the correct way to fix this so Texture::AllocateStorage is always called but he's in the process of ripping out all this code so this CL just makes it work as is (which is what it was doing before except now it has the correct format) https://bugs.webkit.org/show_bug.cgi?id=63638 https://bugs.webkit.org/show_bug.cgi?id=63643 TEST=ran DRT with layout tests mentioned in bugs BUG=none (see above) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
9 years, 5 months ago (2011-06-29 21:10:50 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 5 months ago (2011-06-29 21:11:33 UTC) #2
Ken Russell (switch to Gerrit)
LGTM as long as it's been tested in DRT and Chromium.
9 years, 5 months ago (2011-06-29 21:13:05 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-06-29 23:12:00 UTC) #4
Change committed as 91043

Powered by Google App Engine
This is Rietveld 408576698