Issue 7218046: Revert 90951 - Update V8 to version 3.4.8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7218046: Revert 90951 - Update V8 to version 3.4.8 (Closed)

Created:
9 years, 5 months ago by Torne

Modified:
9 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 90951 - Update V8 to version 3.4.8 Review URL: http://codereview.chromium.org/7284009 TBR=vegorov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90954

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 5 months ago (2011-06-30 10:10:42 UTC) #2

LGTM

Thanks!

v8_shell build in shared library mode is broken and we did not catch it because
we don't test it on our buildbots. 

We add this configuration to our buildbots to avoid such breakages in the
future.

Expand Messages | Collapse Messages