Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Issue 7218041: Merge 89666 - 2011-06-23 Mikhail Naganov <mnaganov@chromium.org> (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/782/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/inspector/front-end/DetailedHeapshotView.js
===================================================================
--- Source/WebCore/inspector/front-end/DetailedHeapshotView.js (revision 89996)
+++ Source/WebCore/inspector/front-end/DetailedHeapshotView.js (working copy)
@@ -420,6 +420,8 @@
this.appendChild(new WebInspector.DataGridNode({path:WebInspector.UIString("Can't find any paths."), len:""}, false));
return;
} else if (result !== false) {
+ if (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow(result.path))
+ result.path = WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL(result.path, true);
if (this._prefix)
result.path = this._prefix + result.path;
var node = new WebInspector.DataGridNode(result, false);
@@ -997,15 +999,15 @@
_getHoverAnchor: function(target)
{
var span = target.enclosingNodeOrSelfWithNodeName("span");
- if (!span || !span.hasStyleClass("console-formatted-string"))
+ if (!span)
return;
var row = target.enclosingNodeOrSelfWithNodeName("tr");
if (!row)
return;
var gridNode = row._dataGridNode;
- if (!gridNode.snapshotNodeIndex)
+ if (!gridNode.hasHoverMessage)
return;
- span.snapshotNodeIndex = gridNode.snapshotNodeIndex;
+ span.node = gridNode;
return span;
},
@@ -1031,18 +1033,17 @@
_showStringContentPopup: function(span)
{
var stringContentElement = document.createElement("span");
- stringContentElement.className = "monospace console-formatted-string";
+ stringContentElement.className = "monospace";
stringContentElement.style.whiteSpace = "pre";
var popover = new WebInspector.Popover(stringContentElement);
- function displayString(names)
+ function displayString(name, className)
{
- if (names.length > 0) {
- stringContentElement.textContent = "\"" + names[0] + "\"";
- popover.show(span);
- }
+ stringContentElement.textContent = name;
+ stringContentElement.className += " " + className;
+ popover.show(span);
}
- this.profileWrapper.nodeFieldValuesByIndex("name", [span.snapshotNodeIndex], displayString);
+ span.node.hoverMessage(displayString);
return popover;
},
« no previous file with comments | « Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js ('k') | Source/WebCore/inspector/front-end/utilities.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698