Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 7218012: Make ToBooleanStub more consistent across platforms. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1404 __ j(not_equal, &call_stub, Label::kNear); 1404 __ j(not_equal, &call_stub, Label::kNear);
1405 __ fldz(); 1405 __ fldz();
1406 __ fld_d(FieldOperand(reg, HeapNumber::kValueOffset)); 1406 __ fld_d(FieldOperand(reg, HeapNumber::kValueOffset));
1407 __ FCmp(); 1407 __ FCmp();
1408 __ j(zero, false_label); 1408 __ j(zero, false_label);
1409 __ jmp(true_label); 1409 __ jmp(true_label);
1410 1410
1411 // The conversion stub doesn't cause garbage collections so it's 1411 // The conversion stub doesn't cause garbage collections so it's
1412 // safe to not record a safepoint after the call. 1412 // safe to not record a safepoint after the call.
1413 __ bind(&call_stub); 1413 __ bind(&call_stub);
1414 ToBooleanStub stub; 1414 ToBooleanStub stub(eax);
1415 __ pushad(); 1415 __ pushad();
1416 __ push(reg); 1416 __ push(reg);
1417 __ CallStub(&stub); 1417 __ CallStub(&stub);
1418 __ test(eax, Operand(eax)); 1418 __ test(eax, Operand(eax));
1419 __ popad(); 1419 __ popad();
1420 EmitBranch(true_block, false_block, not_zero); 1420 EmitBranch(true_block, false_block, not_zero);
1421 } 1421 }
1422 } 1422 }
1423 } 1423 }
1424 1424
(...skipping 3043 matching lines...) Expand 10 before | Expand all | Expand 10 after
4468 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 4468 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
4469 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4469 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4470 } 4470 }
4471 4471
4472 4472
4473 #undef __ 4473 #undef __
4474 4474
4475 } } // namespace v8::internal 4475 } } // namespace v8::internal
4476 4476
4477 #endif // V8_TARGET_ARCH_IA32 4477 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/code-stubs-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698