Use input method to control visibility of virtual keyboard

views/ime/input_method_base.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/ime/input_method_base.h"
 #include "views/view.h"
 #include "views/widget/widget.h"
 
 #include "base/logging.h"
 
@@ skipping 21 matching lines @@
 void InputMethodBase::Init(Widget* widget) {
   DCHECK(widget);
   DCHECK(widget->GetFocusManager());
 
   if (widget_) {
     NOTREACHED() << "The input method is already initialized.";
     return;
   }
 
   widget_ = widget;
+  View* focused = widget->GetFocusManager()->GetFocusedView();
+  if (focused) {
+    OnFocus();
+    FocusWillChange(NULL, focused);
+  }

[sadrul, 2011/06/22 01:47:21]

I think this seeped through from 7222007?

   widget->GetFocusManager()->AddFocusChangeListener(this);
 }
 
 void InputMethodBase::OnFocus() {
   widget_focused_ = true;
 }
 
 void InputMethodBase::OnBlur() {
   widget_focused_ = false;
 }
 
+void InputMethodBase::OnTextInputTypeChanged(View* view) {
+  if (view == focused_view())

[sadrul, 2011/06/22 01:47:21]

Is there a difference between checking 'view == focused_view()' and
'IsViewFocused(view)'? (InputMethodGtk seems to always use the latter)

+    TextInputTypeChanged(focused_view());
+}
+
 TextInputClient* InputMethodBase::GetTextInputClient() const {
   return (widget_focused_ && focused_view_) ?
       focused_view_->GetTextInputClient() : NULL;
 }
 
 ui::TextInputType InputMethodBase::GetTextInputType() const {
   TextInputClient* client = GetTextInputClient();
   return client ? client->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE;
 }
 
 void InputMethodBase::FocusWillChange(View* focused_before, View* focused) {
   DCHECK_EQ(focused_view_, focused_before);
   FocusedViewWillChange();
   focused_view_ = focused;
   FocusedViewDidChange();
+  TextInputTypeChanged(focused_view());

[James Su, 2011/06/22 03:05:15]

Changing focus may not necessarily cause text input type change.

[Peng, 2011/06/22 04:17:39]

Probably the name is not good. It not only notify the type changed but also some
other input related changes.

Maybe rename it to InputStateChanged?

[James Su, 2011/06/22 07:33:28]

IMHO, the current text input type is the only state affecting the virtual
keyboard state. The virtual keyboard should not be changed at all if the text
input type is not changed when moving focus from one text input box to another.
If it's not true, then I think it's better to let the virtual keyboard monitor
the focus change state separately in addition to the text input type state,
rather than using a mixed state.

 }
 
 bool InputMethodBase::IsViewFocused(View* view) const {
   return widget_focused_ && view && focused_view_ == view;
 }
 
 bool InputMethodBase::IsTextInputTypeNone() const {
   return GetTextInputType() == ui::TEXT_INPUT_TYPE_NONE;
 }
 
@@ skipping 30 matching lines @@
   return true;
 }
 
 void InputMethodBase::FocusedViewWillChange() {
 }
 
 void InputMethodBase::FocusedViewDidChange() {
 }
 
 }  // namespace views