Use input method to control visibility of virtual keyboard

views/ime/input_method_base.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/ime/input_method_base.h"
+#include "views/ime/input_method_manager.h"
 #include "views/view.h"
 #include "views/widget/widget.h"
 
 #include "base/logging.h"
 
 namespace views {
 
 InputMethodBase::InputMethodBase()
     : delegate_(NULL),
       widget_(NULL),
@@ skipping 24 matching lines @@
 
   widget_ = widget;
   View* focused = widget->GetFocusManager()->GetFocusedView();
   if (focused)
     FocusWillChange(NULL, focused);
   widget->GetFocusManager()->AddFocusChangeListener(this);
 }
 
 void InputMethodBase::OnFocus() {
   widget_focused_ = true;
+  InputMethodManager *manager = InputMethodManager::GetInstance();
+  manager->OnTextInputTypeChanged(GetTextInputType(), widget_);

[James Su, 2011/07/07 02:03:03]

nit:
1. how about to combine these two lines? The temporary variable is not necessary
here.
2. should we only call OnTextInputTypeChanged() if the text input type is really
changed?

[Peng, 2011/07/07 17:56:54]

Done.
When focus widget is changed, the vk should be notified even if the input type
is same. So it could reset the keyboard state. For example clear caplock and
etc. So I think it necessary to send call it here. Do you have any suggestion?

[James Su, 2011/07/08 02:15:04]

If it's necessary then it's better to state it in comment clearly.

 }
 
 void InputMethodBase::OnBlur() {
   widget_focused_ = false;
+  InputMethodManager *manager = InputMethodManager::GetInstance();
+  manager->OnTextInputTypeChanged(GetTextInputType(), widget_);

[James Su, 2011/07/07 02:03:03]

ditto

[Peng, 2011/07/07 17:56:54]

Done.

+}
+
+void InputMethodBase::OnTextInputTypeChanged(View* view) {
+  if (IsViewFocused(view)) {
+    InputMethodManager *manager = InputMethodManager::GetInstance();
+    manager->OnTextInputTypeChanged(GetTextInputType(), widget_);

[James Su, 2011/07/07 02:03:03]

ditto

[Peng, 2011/07/07 17:56:54]

Done.

+  }
 }
 
 TextInputClient* InputMethodBase::GetTextInputClient() const {
   return (widget_focused_ && focused_view_) ?
       focused_view_->GetTextInputClient() : NULL;
 }
 
 ui::TextInputType InputMethodBase::GetTextInputType() const {
   TextInputClient* client = GetTextInputClient();
   return client ? client->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE;
@@ skipping 37 matching lines @@
   // Widget.
   if (focused_view_->GetWidget() != widget_)
     return Widget::ConvertRect(focused_view_->GetWidget(), widget_, rect);
   return true;
 }
 
 void InputMethodBase::FocusedViewWillChange() {
 }
 
 void InputMethodBase::FocusedViewDidChange() {
+  if (widget_focused_) {
+    InputMethodManager *manager = InputMethodManager::GetInstance();
+    manager->OnTextInputTypeChanged(GetTextInputType(), widget_);
+  }

[James Su, 2011/07/07 02:03:03]

move these code into FocusWillChange(). It may not be called by derived classes
if they override it.

[Peng, 2011/07/07 17:56:54]

Done.

 }
 
 }  // namespace views