Issue 7217005: Fix wrong bounds check on arguments object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7217005: Fix wrong bounds check on arguments object. (Closed)

Created:
9 years, 6 months ago by Karl Klose

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix wrong bounds check on arguments object. TEST=added to test/mjsunit/arguments.js

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	src/objects.cc	View		7 chunks	+7 lines, -7 lines	2 comments	Download
	M	test/mjsunit/arguments.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 6 months ago (2011-06-21 08:57:06 UTC) #2

LGTM.

http://codereview.chromium.org/7217005/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7217005/diff/1/src/objects.cc#newcode3110
src/objects.cc:3110: index < (length - 2) ? parameter_map->get(index + 2) :
NULL;
Are these parentheses really helpful?  Maybe around the whole comparison, they
might help the reader.

http://codereview.chromium.org/7217005/diff/1/src/objects.cc#newcode3557
src/objects.cc:3557: index < (length - 2) ? parameter_map->get(index + 2) :
NULL;
Perhaps add an assert that length is >= 2?

Expand Messages | Collapse Messages