Issue 7216018: Move the Remoting Host plugin into its own sub-directory.

Issue 7216018: Move the Remoting Host plugin into its own sub-directory. (Closed)

Created:
9 years, 6 months ago by Wez

Modified:
9 years, 6 months ago

Reviewers:
Sergey Ulanov, commit-bot: I haz the power

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move the Remoting Host plugin into its own sub-directory. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89901

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments. #

Patch Set 3 : Fix Windows build. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase again. #

Patch Set 6 : Fix missed path in remoting.gyp. #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1433 lines)			Patch
M	remoting/host/disconnect_window_win.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
D	remoting/host/host_plugin.cc	View		1 chunk	+0 lines, -454 lines	0 comments	Download
D	remoting/host/host_plugin.def	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	remoting/host/host_plugin.rc	View		1 chunk	+0 lines, -138 lines	0 comments	Download
D	remoting/host/host_plugin-Info.plist	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	remoting/host/host_plugin_resource.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
D	remoting/host/host_plugin_utils.h	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	remoting/host/host_plugin_utils.cc	View		1 chunk	+0 lines, -43 lines	0 comments	Download
D	remoting/host/host_script_object.h	View	1 2 3 4	1 chunk	+0 lines, -149 lines	0 comments	Download
D	remoting/host/host_script_object.cc	View	1 2 3 4	1 chunk	+0 lines, -528 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin.def	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin.rc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin-Info.plist	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin_resource.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin_utils.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	remoting/host/plugin/host_plugin_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	remoting/host/plugin/host_script_object.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	remoting/host/plugin/host_script_object.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 2 3 4 5	5 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Just some nits. LGTM if they are fixed. http://codereview.chromium.org/7216018/diff/1/remoting/host/plugin/host_plugin_utils.h File remoting/host/plugin/host_plugin_utils.h (right): http://codereview.chromium.org/7216018/diff/1/remoting/host/plugin/host_plugin_utils.h#newcode5 remoting/host/plugin/host_plugin_utils.h:5: #ifndef ...

9 years, 6 months ago (2011-06-21 18:19:31 UTC) #2

commit-bot: I haz the power

9 years, 6 months ago (2011-06-21 20:44:51 UTC) #3

Can't process patch for file remoting/host/plugin/host_plugin.cc.
A +

Expand Messages | Collapse Messages