Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/objects-inl.h

Issue 7216007: Use issue number instead of username for TODO comment (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2042 matching lines...) Expand 10 before | Expand all | Expand 10 after
2053 template <typename Shape, typename Key> 2053 template <typename Shape, typename Key>
2054 HashTable<Shape, Key>* HashTable<Shape, Key>::cast(Object* obj) { 2054 HashTable<Shape, Key>* HashTable<Shape, Key>::cast(Object* obj) {
2055 ASSERT(obj->IsHashTable()); 2055 ASSERT(obj->IsHashTable());
2056 return reinterpret_cast<HashTable*>(obj); 2056 return reinterpret_cast<HashTable*>(obj);
2057 } 2057 }
2058 2058
2059 2059
2060 SMI_ACCESSORS(FixedArrayBase, length, kLengthOffset) 2060 SMI_ACCESSORS(FixedArrayBase, length, kLengthOffset)
2061 SMI_ACCESSORS(ByteArray, length, kLengthOffset) 2061 SMI_ACCESSORS(ByteArray, length, kLengthOffset)
2062 2062
2063 // TODO(jkummerow): Investigate if it's possible to s/INT/SMI/ here (and 2063 // TODO(1493): Investigate if it's possible to s/INT/SMI/ here (and
2064 // subsequently unify H{Fixed,External}ArrayLength). 2064 // subsequently unify H{Fixed,External}ArrayLength).
2065 INT_ACCESSORS(ExternalArray, length, kLengthOffset) 2065 INT_ACCESSORS(ExternalArray, length, kLengthOffset)
2066 2066
2067 2067
2068 SMI_ACCESSORS(String, length, kLengthOffset) 2068 SMI_ACCESSORS(String, length, kLengthOffset)
2069 2069
2070 2070
2071 uint32_t String::hash_field() { 2071 uint32_t String::hash_field() {
2072 return READ_UINT32_FIELD(this, kHashFieldOffset); 2072 return READ_UINT32_FIELD(this, kHashFieldOffset);
2073 } 2073 }
(...skipping 2346 matching lines...) Expand 10 before | Expand all | Expand 10 after
4420 #undef WRITE_INT_FIELD 4420 #undef WRITE_INT_FIELD
4421 #undef READ_SHORT_FIELD 4421 #undef READ_SHORT_FIELD
4422 #undef WRITE_SHORT_FIELD 4422 #undef WRITE_SHORT_FIELD
4423 #undef READ_BYTE_FIELD 4423 #undef READ_BYTE_FIELD
4424 #undef WRITE_BYTE_FIELD 4424 #undef WRITE_BYTE_FIELD
4425 4425
4426 4426
4427 } } // namespace v8::internal 4427 } } // namespace v8::internal
4428 4428
4429 #endif // V8_OBJECTS_INL_H_ 4429 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698