base/metrics/histogram.cc - Issue 7215034: Apply CSP to chrome: and about: pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram.cc

Issue 7215034: Apply CSP to chrome: and about: pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram.cc

===================================================================

--- base/metrics/histogram.cc (revision 90144)

+++ base/metrics/histogram.cc (working copy)

@@ -1064,13 +1064,6 @@

std::string* output) {

if (!IsActive())

return;

- output->append("<html><head><title>About Histograms");

- if (!query.empty())

- output->append(" - " + query);

abarth-chromium 2011/06/24 04:45:18 I can haz XSS?

Evan Martin 2011/06/24 18:05:32 Well, given that you can't link to these pages, yo

abarth-chromium 2011/06/24 18:07:56 We've fixed the pasting attacks we know of (at lea

- output->append("</title>"

- // We'd like the following no-cache... but it doesn't work.

- // "<META HTTP-EQUIV=\"Pragma\" CONTENT=\"no-cache\">"

- "</head><body>");

Histograms snapshot;

GetSnapshot(query, &snapshot);

@@ -1080,7 +1073,6 @@

(*it)->WriteHTMLGraph(output);

output->append("<br><hr><br>");

}

- output->append("</body></html>");

}

// static

« no previous file with comments | « no previous file | base/tracked_objects.h » ('j') | chrome/browser/browser_about_handler.cc » ('J')