Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7164)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/about_stats.html

Issue 7215034: Apply CSP to chrome: and about: pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_memory_mac.html ('k') | chrome/browser/resources/about_stats.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/about_stats.html
===================================================================
--- chrome/browser/resources/about_stats.html (revision 90431)
+++ chrome/browser/resources/about_stats.html (working copy)
@@ -1,9 +1,13 @@
<!DOCTYPE HTML>
<html id="t">
- <head>
- <title>About Stats</title>
-
+<head>
+<title>About Stats</title>
+<!-- X-WebKit-CSP is our development name for Content-Security-Policy.
+ The 'unsafe-eval' is required for jstemplate_compiled.js.
+ TODO(tsepez) rename when Content-security-policy is done.
+-->
+<meta http-equiv="X-WebKit-CSP" content="object-src 'none'; script-src chrome://resources 'self' 'unsafe-eval'">
<style>
body {
border-top: 10px solid #3B85E3;
@@ -70,194 +74,11 @@
text-transform: lowercase;
}
</style>
-<script>
-
-/* Counter accessor for Name Node. */
-function getCounterNameFromCounterNode(node) {
- return node.childNodes[1];
-}
-
-/* Counter accessor for Value Node. */
-function getCounterValueFromCounterNode(node) {
- return node.childNodes[3];
-}
-
-/* Counter accessor for Delta Node. */
-function getCounterDeltaFromCounterNode(node) {
- return node.childNodes[5];
-}
-
-/* Timer accessor for Name Node. */
-function getTimerNameFromTimerNode(node) {
- return node.childNodes[1];
-}
-
-/* Timer accessor for Value Node. */
-function getTimerValueFromTimerNode(node) {
- return node.childNodes[3];
-}
-
-/* Timer accessor for Time Node. */
-function getTimerTimeFromTimerNode(node) {
- return node.childNodes[5];
-}
-
-/* Timer accessor for Average Time Node. */
-function getTimerAvgTimeFromTimerNode(node) {
- return node.childNodes[7];
-}
-
-/* Do the filter work. Hide all nodes matching node.*/
-function filterMatching(text, nodelist, functionToGetNameNode) {
- var showAll = text.length == 0;
- for (var i = 0, node; node = nodelist[i]; i++) {
- var name = functionToGetNameNode(node).innerHTML.toLowerCase();
- if (showAll || name.indexOf(text) >= 0) {
- node.style.display = "table-row";
- } else {
- node.style.display = "none";
- }
- }
-}
-
-/* Hides or shows counters based on the user's current filter selection. */
-function doFilter() {
- var filter = document.getElementById("filter");
- var text = filter.value.toLowerCase();
- var nodes = document.getElementsByName("counter");
- filterMatching(text, nodes, getCounterNameFromCounterNode);
- var nodes = document.getElementsByName("timer");
- filterMatching(text, nodes, getTimerNameFromTimerNode);
-}
-
-/* Colors the counters based on increasing or decreasing value. */
-function doColor() {
- var nodes = document.getElementsByName("counter");
- for (var i = 0, node; node = nodes[i]; i++) {
- var child = getCounterDeltaFromCounterNode(node);
- var delta = child.innerHTML;
- if (delta > 0) {
- child.style.color = "Green";
- } else if (delta == 0) {
- child.style.color = "Black";
- } else {
- child.style.color = "Red";
- }
- }
-}
-
-/* Counters with no values are null. Remove them. */
-function removeNullValues() {
- var nodes = document.getElementsByName("counter");
- for (var i = nodes.length - 1; i >= 0; i--) {
- var node = nodes[i];
- var value = getCounterValueFromCounterNode(node).innerHTML;
- if (value == "null") {
- node.parentNode.removeChild(node);
- }
- }
- var nodes = document.getElementsByName("timer");
- for (var i = 0, node; node = nodes[i]; i++) {
- var value_node = getTimerValueFromTimerNode(node);
- if (value_node.innerHTML == "null") {
- value_node.innerHTML = "";
- }
- }
-}
-
-/* Compute the average time for timers */
-function computeTimes() {
- var nodes = document.getElementsByName("timer");
- for (var i = 0, node; node = nodes[i]; i++) {
- var count = getTimerValueFromTimerNode(node).innerHTML;
- if (count.length > 0) {
- var time = getTimerTimeFromTimerNode(node).innerHTML;
- var avg = getTimerAvgTimeFromTimerNode(node);
- avg.innerHTML = Math.round(time / count * 100) / 100;
- }
- }
-}
-
-/* All the work we do onload. */
-function onLoadWork() {
- doColor();
- removeNullValues();
- computeTimes();
- document.getElementById("filter").focus();
-}
-
-// The function should only be used as the event handler
-// on a table cell element. To use it, put it in a <td> element:
-// <td onclick="sort('string')" ...>
-//
-// The function sorts rows after the row with onclick event handler.
-//
-// type: the data type, 'string', 'number'
-function sort_table(type){
- var cell = event.target;
- var cnum = cell.cellIndex;
-
- var row = cell.parentNode;
- var start_index = row.rowIndex + 1;
-
- var tbody = row.parentNode;
- var table = tbody.parentNode;
-
- var rows = new Array();
-
- var indexes = new Array();
- // skip the first row
- for (var i = start_index; i < table.rows.length; i++)
- rows.push(table.rows[i]);
-
- // a, b are strings
- function compare_strings(a,b) {
- if (a == b) return 0;
- if (a < b) return -1;
- return 1;
- }
-
- // a, b are numbers
- function compare_numbers(a,b) {
- var x = isNaN(a) ? 0 : a;
- var y = isNaN(b) ? 0 : b;
- return x - y;
- }
-
- var sort_func = undefined;
- if (type === 'string') {
- sort_func = function(a, b) {
- var x = a.cells[cnum].innerText;
- var y = b.cells[cnum].innerText;
- return compare_strings(x, y);
- } ;
-
- } else if (type === 'number') {
- sort_func = function(a, b) {
- var x = parseFloat(a.cells[cnum].innerText);
- var y = parseFloat(b.cells[cnum].innerText);
- return compare_numbers(x, y);
- }
- }
-
- rows.sort(sort_func);
-
- // change tables
- if (cell._reverse) {
- for (var i = rows.length - 1; i >= 0; i--)
- tbody.appendChild(rows[i]);
- cell._reverse = false;
- } else {
- for (var i = 0; i < rows.length; i++)
- tbody.appendChild(rows[i]);
- cell._reverse = true;
- }
-}
-
-</script>
+<script src="chrome://stats/stats.js"></script>
+<script src="chrome://stats/json.js"></script>
</head>
-<body onload="onLoadWork()">
- <div style="float: right">
+<body>
+ <div style="float: right">
<br>Filter: <input id="filter" type="text" value="" onkeyup="doFilter()">
</div>
<h1 class="lower">About Stats</h1>
@@ -273,9 +94,9 @@
<td class="top value" colspan=2></td>
</tr>
<tr>
- <td class="header2 lower" width="200" onclick="sort_table('string')">name</td>
- <td class="header2 lower" onclick="sort_table('number')">value</td>
- <td class="header2 lower" onclick="sort_table('number')">delta</td>
+ <td class="header2 lower" name="string-sort" width="200">name</td>
+ <td class="header2 lower" name="number-sort">value</td>
+ <td class="header2 lower" name="number-sort">delta</td>
</tr>
<tr jsselect="counters" name="counter">
<td class="key" width="200" jscontent="name"></td>
@@ -295,10 +116,10 @@
<td class="top value" colspan=3></td>
</tr>
<tr>
- <td class="header2 lower" width="200" onclick="sort_table('string')">name</td>
- <td class="header2 lower" onclick="sort_table('number')">count</td>
- <td class="header2 lower" onclick="sort_table('number')">time (ms)</td>
- <td class="header2 lower" onclick="sort_table('number')">avg time (ms)</td>
+ <td class="header2 lower" name="string-sort" width="200">name</td>
+ <td class="header2 lower" name="number-sort">count</td>
+ <td class="header2 lower" name="number-sort">time (ms)</td>
+ <td class="header2 lower" name="number-sort">avg time (ms)</td>
</tr>
<tr jsselect="timers" name="timer">
<td class="key" width="200" jscontent="name"></td>
@@ -312,5 +133,7 @@
</tr>
</tbody>
</table><br/>
+ <script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
</html>
+
« no previous file with comments | « chrome/browser/resources/about_memory_mac.html ('k') | chrome/browser/resources/about_stats.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698