Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 7215030: Don't copy the Graphics2D when binding a new one. This brings the (Closed)

Created:
9 years, 6 months ago by brettw
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't copy the Graphics2D when binding a new one. This brings the implementation in line with the interface documentation (the old behavior would clobber any content). The copying behavior was introduced to avoid flickering when resizing. To avoid this, the PaintManager now doesn't bind the new device until it's been painted to. This gives flicker-free painting. This fixes a bug in the paint manager example that made it not paint. TEST=manual BUG=86568 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90386

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -72 lines) Patch
M ppapi/cpp/paint_manager.h View 1 2 3 chunks +18 lines, -3 lines 0 comments Download
M ppapi/cpp/paint_manager.cc View 6 chunks +63 lines, -38 lines 0 comments Download
M ppapi/examples/2d/paint_manager_example.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 2 3 1 chunk +30 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
9 years, 6 months ago (2011-06-21 19:12:41 UTC) #1
jam
I'm sure this code works fine. However, if this gets changed, the pdf code's heavily ...
9 years, 6 months ago (2011-06-21 21:36:53 UTC) #2
brettw
On Tue, Jun 21, 2011 at 2:36 PM, <jam@chromium.org> wrote: > I'm sure this code ...
9 years, 6 months ago (2011-06-21 21:48:16 UTC) #3
brettw
This fixes the black resizing artifacts for the PDF plugin
9 years, 6 months ago (2011-06-22 22:07:08 UTC) #4
jam
lgtm
9 years, 6 months ago (2011-06-22 22:08:32 UTC) #5
jam
9 years, 6 months ago (2011-06-23 18:29:50 UTC) #6
please ping me when you land this so that I can do the pdf side patch soon after

Powered by Google App Engine
This is Rietveld 408576698