Issue 7215027: Coverity: Initialize member variables.

Issue 7215027: Coverity: Initialize member variables. (Closed)

Created:
9 years, 6 months ago by James Hawkins

Modified:
9 years, 2 months ago

Reviewers:
Mike Mammarella, kmadhusu

CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), kinuko+watch, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Coverity: Initialize member variables. CID=9299,13805,14203,14284,14459,15435,15897,16023,16614,16773,16819,16820, 16908,16916 BUG=none TEST=none R=kmadhusu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89897

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -12 lines)			Patch
M	media/filters/ffmpeg_demuxer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/listen_socket.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/proxy/proxy_config_service_linux.cc	View	1 chunk	+28 lines, -3 lines	2 comments	Download
M	net/socket/ssl_client_socket_pool.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/fileapi/file_system_directory_database.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/fileapi/file_system_file_util_proxy.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/fileapi/file_system_operation_context.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/glue_serialize.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_instance.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/message_channel.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_audio_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_widget_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

http://codereview.chromium.org/7215027/diff/1/net/proxy/proxy_config_service_linux.cc File net/proxy/proxy_config_service_linux.cc (right): http://codereview.chromium.org/7215027/diff/1/net/proxy/proxy_config_service_linux.cc#newcode496 net/proxy/proxy_config_service_linux.cc:496: GSettings* (*g_settings_new)(const gchar* schema); Hey, what's with this #if ...

9 years, 3 months ago (2011-09-23 20:27:26 UTC) #3

James Hawkins

9 years, 2 months ago (2011-09-26 03:13:14 UTC) #4

http://codereview.chromium.org/7215027/diff/1/net/proxy/proxy_config_service_...
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/7215027/diff/1/net/proxy/proxy_config_service_...
net/proxy/proxy_config_service_linux.cc:496: GSettings* (*g_settings_new)(const
gchar* schema);
On 2011/09/23 20:27:26, Mike Mammarella wrote:
> Hey, what's with this #if 0 block?

Dead, temporary code.  Should be removed.

Expand Messages | Collapse Messages