Issue 7215003: Multi-tab: Adding new Notification when tab selection changes (again).

Issue 7215003: Multi-tab: Adding new Notification when tab selection changes (again). (Closed)

Created:
9 years, 6 months ago by dpapad

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, sky

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Multi-tab: Adding new Notification when tab selection changes (again). This is mostly a copy of http://codereview.chromium.org/7033048/ which was reverted. Only changes from 7033048 are 1) Fixing linux_touch trivial compile_error. 2) Adding <iterator> header in chrome/browser/ui/views/tabs/tab_strip.cc because Win Builder 2010 failed because of that. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90155

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Rebasing #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -131 lines)			Patch
M	chrome/browser/aeropeek_manager.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_event_router.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.h	View		1 chunk	+16 lines, -9 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View		8 chunks	+59 lines, -53 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_observer.h	View		2 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_observer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_order_controller.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View		13 chunks	+122 lines, -12 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_selection_model.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_selection_model.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_selection_model_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/touch/frame/touch_browser_frame_view.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/touch/tabs/touch_tab_strip.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/touch/tabs/touch_tab_strip.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/base_tab_strip.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/side_tab_strip.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/side_tab_strip.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View		3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dpapad

I think that the test failures are not related to my changes (different tests fail ...

9 years, 6 months ago (2011-06-22 21:56:01 UTC) #1

Change committed as 90155

Expand Messages | Collapse Messages