Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/ui/touch/keyboard/keyboard_manager.cc

Issue 7212029: Add a browser-test for the keyboard widget. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/touch/keyboard/keyboard_manager.cc
diff --git a/chrome/browser/ui/touch/keyboard/keyboard_manager.cc b/chrome/browser/ui/touch/keyboard/keyboard_manager.cc
index d63f79b7f155233388dacfe48b1c81ef32dc1837..d707c225f2598dafe788be93447a37c6635d70e2 100644
--- a/chrome/browser/ui/touch/keyboard/keyboard_manager.cc
+++ b/chrome/browser/ui/touch/keyboard/keyboard_manager.cc
@@ -14,8 +14,8 @@
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
#include "chrome/browser/ui/views/dom_view.h"
#include "chrome/browser/ui/views/tab_contents/tab_contents_view_touch.h"
-#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/url_constants.h"
#include "content/browser/site_instance.h"
#include "content/browser/tab_contents/tab_contents.h"
@@ -212,10 +212,22 @@ void KeyboardWidget::ShowKeyboardForWidget(views::Widget* widget) {
MoveToTop();
Show();
+
+ bool visible = true;
+ NotificationService::current()->Notify(
+ chrome::NOTIFICATION_KEYBOARD_VISIBILITY_CHANGED,
+ Source<KeyboardWidget>(this),
+ Details<bool>(&visible));
}
void KeyboardWidget::Hide() {
animation_->Hide();
+
+ bool visible = false;
+ NotificationService::current()->Notify(
+ chrome::NOTIFICATION_KEYBOARD_VISIBILITY_CHANGED,
+ Source<KeyboardWidget>(this),
+ Details<bool>(&visible));
}
void KeyboardWidget::SetTarget(views::Widget* target) {

Powered by Google App Engine
This is Rietveld 408576698