Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: tools/gyp/v8.gyp

Issue 7212014: Allow compiling v8_shell with the 'host' toolset. (Closed) Base URL: http://v8.googlecode.com/svn/trunk/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
===================================================================
--- tools/gyp/v8.gyp (revision 8294)
+++ tools/gyp/v8.gyp (working copy)
@@ -232,6 +232,7 @@
'targets': [
{
'target_name': 'v8',
+ 'toolsets': ['host', 'target'],
'conditions': [
['v8_use_snapshot=="true"', {
'dependencies': ['v8_snapshot'],
@@ -281,6 +282,7 @@
{
'target_name': 'v8_snapshot',
'type': '<(library)',
+ 'toolsets': ['host', 'target'],
'conditions': [
['component=="shared_library"', {
'conditions': [
@@ -954,6 +956,7 @@
{
'target_name': 'v8_shell',
'type': 'executable',
+ 'toolsets': ['host'],
Søren Thygesen Gjesse 2011/06/21 08:19:02 Shouldn't we build v8_shell for the target while w
Sheridan Rawlins 2011/06/21 14:41:19 Building type executable for both causes collision
'dependencies': [
'v8'
],
@@ -977,6 +980,7 @@
{
'target_name': 'v8',
'type': 'settings',
+ 'toolsets': ['host', 'target'],
'link_settings': {
'libraries': [
'-lv8',
@@ -986,6 +990,7 @@
{
'target_name': 'v8_shell',
'type': 'none',
+ 'toolsets': ['host'],
Søren Thygesen Gjesse 2011/06/21 08:19:02 Ditto.
Sheridan Rawlins 2011/06/21 14:41:19 Ditto On 2011/06/21 08:19:02, Søren Gjesse wrote:
'dependencies': [
'v8'
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698