Issue 7211013: Combined identical classes V8JavaScriptScanner and StandAloneJavaScriptScanner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7211013: Combined identical classes V8JavaScriptScanner and StandAloneJavaScriptScanner. (Closed)

Created:
9 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Combined identical classes V8JavaScriptScanner and StandAloneJavaScriptScanner. Now only uses the common superclass of the two scanner classes. Updated comment on KeywordMatcher. Committed: http://code.google.com/p/v8/source/detail?r=8362

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -65 lines)			Patch
M	src/parser.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/preparser-api.cc	View	2 chunks	+1 line, -18 lines	0 comments	Download
M	src/scanner.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/scanner.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/scanner-base.h	View	2 chunks	+15 lines, -7 lines	0 comments	Download
M	src/scanner-base.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages