ARM: Reduce amount of code generated for LoadIC_Megamorphic....

src/ia32/stub-cache-ia32.cc

Index: src/ia32/stub-cache-ia32.cc
===================================================================
--- src/ia32/stub-cache-ia32.cc	(revision 8507)
+++ src/ia32/stub-cache-ia32.cc	(working copy)
@@ -164,7 +164,8 @@
                               Register name,
                               Register scratch,
                               Register extra,
-                              Register extra2) {
+                              Register extra2,
+                              Register extra3) {
   Isolate* isolate = Isolate::Current();
   Label miss;
   USE(extra2);  // The register extra2 is not used on the ia32 platform.

[Søren Thygesen Gjesse, 2011/07/04 07:21:19]

Will a USE(extra3) be needed to compile in release mode?

[m.m.capewell, 2011/07/14 15:00:18]

Done.

@@ -183,9 +184,10 @@
   ASSERT(!extra.is(name));
   ASSERT(!extra.is(scratch));
 
-  // Check scratch and extra registers are valid, and extra2 is unused.
+  // Check scratch is valid, extra2 and extra3 are unused.
   ASSERT(!scratch.is(no_reg));

[Søren Thygesen Gjesse, 2011/07/04 07:21:19]

Also assert that extra is not no_reg?

[m.m.capewell, 2011/07/14 15:00:18]

extra can be no_reg here, eg. ic-ia32.cc:877.

   ASSERT(extra2.is(no_reg));
+  ASSERT(extra3.is(no_reg));
 
   // Check that the receiver isn't a smi.
   __ JumpIfSmi(receiver, &miss);