ovda_unittest: sets wrap_s&t parameters to textures

ovda_unittest: sets wrap_s&t parameters to textures

Add the code to set wrap_s, and wrap_t parameters
to textures.

Bug=None
Test=omx_video_decode_accelerator_unittest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91673

[ashok, 2011-07-01 09:27:19]

These two extra attributes needs to be set, because of extra restrictions are
added in the new version of GLES driver.

[vhiremath, 2011-07-01 09:32:01]

LGTM

[Ami GONE FROM CHROMIUM, 2011-07-01 16:16:04]

I see nothing wrong here but want more info.

http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right):

http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:312:
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
Why GL_CLAMP_TO_EDGE vs. other settings?  
What happens with the new drivers if these are not set?

[ashok, 2011-07-04 05:29:21]

On 2011/07/01 16:16:04, Ami Fischman wrote:
> I see nothing wrong here but want more info.
> 
>
http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_vi...
> File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc
(right):
> 
>
http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_vi...
> content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:312:
> glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
> Why GL_CLAMP_TO_EDGE vs. other settings?  
> What happens with the new drivers if these are not set?

If these are not set, EGL Image creation will be failed with the new EGL driver.

[Ami GONE FROM CHROMIUM, 2011-07-04 16:18:54]

> If these are not set, EGL Image creation will be failed with the new EGL
driver.

Isn't that a bug in the new EGL driver?

http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexParameter.xml specifies
initial values for these parameters, so it's not that they are undefined.  Are
you saying that the new EGL driver fails when these parameters are set to
GL_REPEAT?

[Michael I Gold, 2011-07-06 17:36:35]

On 2011/07/04 16:18:54, Ami Fischman wrote:
> > If these are not set, EGL Image creation will be failed with the new EGL
> driver.
> 
> Isn't that a bug in the new EGL driver?
> 
> http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexParameter.xml
specifies
> initial values for these parameters, so it's not that they are undefined.  Are
> you saying that the new EGL driver fails when these parameters are set to
> GL_REPEAT?

The fact it worked before was a driver bug.  GLES2 support for NPOT texture is
limited and requires a wrap mode of CLAMP_TO_EDGE.  Some implementations support
ARB_texture_non_power_of_two and relax this restriction but T2 does not support
this extension.  If the wrap mode is not set to a supported value the texture
completeness check fails and the texture is disabled.

I don't know if eglCreateImageKHR itself actually fails - if creating from an
incomplete texture, it might.

[Ami GONE FROM CHROMIUM, 2011-07-06 17:52:49]

Now I see; this restriction is described in section 3.8.2 of
http://www.khronos.org/registry/gles/specs/2.0/es_full_spec_2.0.25.pdf
Michael: Thanks for the details.
Ashok: can you add a comment above the new lines in question stating:
// OpenGLES2.0.25 section 3.8.2 requires CLAMP_TO_EDGE for NPOT textures.
?

Once you do that I'll LGTM & check the commit box.

[ashok, 2011-07-07 06:07:53]

On 2011/07/06 17:52:49, Ami Fischman wrote:
> Now I see; this restriction is described in section 3.8.2 of
> http://www.khronos.org/registry/gles/specs/2.0/es_full_spec_2.0.25.pdf
> Michael: Thanks for the details.
> Ashok: can you add a comment above the new lines in question stating:
> // OpenGLES2.0.25 section 3.8.2 requires CLAMP_TO_EDGE for NPOT textures.
> ?
> 
> Once you do that I'll LGTM & check the commit box.

Ami,
Added the comment.
Also upload the same change for sample plug-in also.

-ashok m

[Ami GONE FROM CHROMIUM, 2011-07-07 06:15:15]

LGTM

[Ami GONE FROM CHROMIUM, 2011-07-07 06:16:29]

> Also upload the same change for sample plug-in also.

I'm not sure what you mean by this.  The gles2.cc sample already sets
GL_CLAMP_TO_EDGE on its textures.

[ashok, 2011-07-07 06:29:16]

On 2011/07/07 06:16:29, Ami Fischman wrote:
> > Also upload the same change for sample plug-in also.
> 
> I'm not sure what you mean by this.  The gles2.cc sample already sets
> GL_CLAMP_TO_EDGE on its textures.

I haven't checked the gles2.cc. 
And assumed that it won't have this change.

[commit-bot: I haz the power, 2011-07-07 07:31:07]

Change committed as 91673