Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7210055: ovda_unittest: sets wrap_s&t parameters to textures (Closed)

Created:
9 years, 5 months ago by ashok
Modified:
9 years, 5 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

ovda_unittest: sets wrap_s&t parameters to textures Add the code to set wrap_s, and wrap_t parameters to textures. Bug=None Test=omx_video_decode_accelerator_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91673

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/common/gpu/media/omx_video_decode_accelerator_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ashok
These two extra attributes needs to be set, because of extra restrictions are added in ...
9 years, 5 months ago (2011-07-01 09:27:19 UTC) #1
vhiremath
LGTM
9 years, 5 months ago (2011-07-01 09:32:01 UTC) #2
Ami GONE FROM CHROMIUM
I see nothing wrong here but want more info. http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right): http://codereview.chromium.org/7210055/diff/1/content/common/gpu/media/omx_video_decode_accelerator_unittest.cc#newcode312 content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:312: ...
9 years, 5 months ago (2011-07-01 16:16:04 UTC) #3
ashok
On 2011/07/01 16:16:04, Ami Fischman wrote: > I see nothing wrong here but want more ...
9 years, 5 months ago (2011-07-04 05:29:21 UTC) #4
Ami GONE FROM CHROMIUM
> If these are not set, EGL Image creation will be failed with the new ...
9 years, 5 months ago (2011-07-04 16:18:54 UTC) #5
Michael I Gold
On 2011/07/04 16:18:54, Ami Fischman wrote: > > If these are not set, EGL Image ...
9 years, 5 months ago (2011-07-06 17:36:35 UTC) #6
Ami GONE FROM CHROMIUM
Now I see; this restriction is described in section 3.8.2 of http://www.khronos.org/registry/gles/specs/2.0/es_full_spec_2.0.25.pdf Michael: Thanks for ...
9 years, 5 months ago (2011-07-06 17:52:49 UTC) #7
ashok
On 2011/07/06 17:52:49, Ami Fischman wrote: > Now I see; this restriction is described in ...
9 years, 5 months ago (2011-07-07 06:07:53 UTC) #8
Ami GONE FROM CHROMIUM
LGTM
9 years, 5 months ago (2011-07-07 06:15:15 UTC) #9
Ami GONE FROM CHROMIUM
> Also upload the same change for sample plug-in also. I'm not sure what you ...
9 years, 5 months ago (2011-07-07 06:16:29 UTC) #10
ashok
On 2011/07/07 06:16:29, Ami Fischman wrote: > > Also upload the same change for sample ...
9 years, 5 months ago (2011-07-07 06:29:16 UTC) #11
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 07:31:07 UTC) #12
Change committed as 91673

Powered by Google App Engine
This is Rietveld 408576698