Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: tools/valgrind/memcheck/suppressions.txt

Issue 7210053: Implementation of PostTaskAndReply() in MessageLoopProxy and BrowserThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add supression Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_thread_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/memcheck/suppressions.txt
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index 17f258bb2552aa9e83c1df8cd0b9ea88fdd86a04..ee5c880c301929bb7533f02bd7f9cfbdc4fc10aa 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -745,6 +745,13 @@
fun:_ZN4base40ToolsSanityTest_AccessesToNewMemory_Test8TestBodyEv
}
{
+ This test explicitly verifies PostTaskAndReply leaks the task if the originating MessageLoop has been deleted.
Nico 2011/08/18 18:05:28 No bug #?
awong 2011/08/18 18:18:56 I'm not sure it is a bug...
Nico 2011/08/18 18:32:34 I meant more "See http://crbug.com/86301" to save
+ Memcheck:Leak
+ fun:_Znw*
+ fun:_ZN4base16MessageLoopProxy16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_
+ fun:_ZN4base12_GLOBAL__N_169MessageLoopProxyTest_PostTaskAndReply_DeadReplyLoopDoesNotDelete_Test8TestBodyEv
Nico 2011/08/18 18:05:28 GLOBAL might mangle differently on OS X, don't rem
awong 2011/08/18 18:18:56 Okay I don't have a mac handy. Will watch the wate
+}
+{
logging::InitLogging never frees filename. It would be hard to free properly.
Memcheck:Leak
...
« no previous file with comments | « content/browser/browser_thread_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698