Issue 7210049: Update contentscript xhr example to remove background page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7210049: Update contentscript xhr example to remove background page. (Closed)

Created:
9 years, 5 months ago by kurrik.chromium

Modified:
9 years, 5 months ago

Reviewers:
kurrik, Boris Smus, kathyw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update contentscript xhr example to remove background page. BUG=88121 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91623

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with Kathy's feedback" #

Patch Set 3 : Rebuilding docs #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -148 lines)			Patch
	chrome/common/extensions/docs/examples/howto/contentscript_xhr.zip	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/common/extensions/docs/examples/howto/contentscript_xhr/background.html	View		1 chunk	+0 lines, -55 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/howto/contentscript_xhr/contentscript.js	View	1 2	1 chunk	+51 lines, -26 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/howto/contentscript_xhr/manifest.json	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.html	View	1	3 chunks	+34 lines, -38 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 2	2 chunks	+19 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kathyw

9 years, 5 months ago (2011-07-01 00:30:14 UTC) #2

LGTM

(from a public string perspective)

Just one comment to prove I really looked.

http://codereview.chromium.org/7210049/diff/1/chrome/common/extensions/docs/e...
File
chrome/common/extensions/docs/examples/howto/contentscript_xhr/manifest.json
(right):

http://codereview.chromium.org/7210049/diff/1/chrome/common/extensions/docs/e...
chrome/common/extensions/docs/examples/howto/contentscript_xhr/manifest.json:2:
"name": "Content Script Crossdomain XMLHttpRequest Example",
Crossdomain -> Cross-Domain

Expand Messages | Collapse Messages